KVM: ioapic: fix assignment of ioapic->rtc_status.pending_eoi (CVE-2014-0155)
authorPaolo Bonzini <pbonzini@redhat.com>
Fri, 28 Mar 2014 19:41:50 +0000 (20:41 +0100)
committerPaolo Bonzini <pbonzini@redhat.com>
Fri, 4 Apr 2014 15:17:14 +0000 (17:17 +0200)
commit5678de3f15010b9022ee45673f33bcfc71d47b60
treef1de2ce3a27fe310faea6a252a88bce39946383c
parent7cbb39d4d4d530dff12f2ff06ed6c85c504ba91a
KVM: ioapic: fix assignment of ioapic->rtc_status.pending_eoi (CVE-2014-0155)

QE reported that they got the BUG_ON in ioapic_service to trigger.
I cannot reproduce it, but there are two reasons why this could happen.

The less likely but also easiest one, is when kvm_irq_delivery_to_apic
does not deliver to any APIC and returns -1.

Because irqe.shorthand == 0, the kvm_for_each_vcpu loop in that
function is never reached.  However, you can target the similar loop in
kvm_irq_delivery_to_apic_fast; just program a zero logical destination
address into the IOAPIC, or an out-of-range physical destination address.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
virt/kvm/ioapic.c