[media] drivers: media: i2c: ml86v7667: constify v4l2_subdev_* structures
authorBhumika Goyal <bhumirks@gmail.com>
Tue, 13 Dec 2016 17:31:45 +0000 (15:31 -0200)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Fri, 3 Feb 2017 11:34:43 +0000 (09:34 -0200)
commit5610ced4f13d5d864773ee2aa63e7cd9c3ca1c04
tree54416f0a3ab55149949096890cbd475bdaf2ea1a
parent4d7aa5e9911c47cb40b0a5ed1b192ff50f4d6832
[media] drivers: media: i2c: ml86v7667: constify v4l2_subdev_* structures

v4l2_subdev_{core/video}_ops structures are stored in the
fields of the v4l2_subdev_ops structure which are of type const.
Also, v4l2_subdev_ops structure is passed to a function
having its argument of type const. As these structures are never
modified, so declare them as const.
Done using Coccinelle: (One of the scripts used)

@r1 disable optional_qualifier @
identifier i;
position p;
@@
static struct v4l2_subdev_ops i@p = {...};

@ok1@
identifier r1.i;
position p;
@@
v4l2_i2c_subdev_init(...,&i@p)

@bad@
position p!={r1.p,ok1.p};
identifier r1.i;
@@
i@p

@depends on !bad disable optional_qualifier@
identifier r1.i;
@@
+const
struct v4l2_subdev_ops i;

File size before:
  text    data     bss     dec     hex filename
   2732     608       8    3348     d14 drivers/media/i2c/ml86v7667.o

File size after:
  text    data     bss     dec     hex filename
   3100     232       8    3340     d0c drivers/media/i2c/ml86v7667.o

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/i2c/ml86v7667.c