xen: do not respond to unknown xenstore control requests
authorIan Campbell <ian.campbell@citrix.com>
Thu, 17 Feb 2011 11:04:20 +0000 (11:04 +0000)
committerStefano Stabellini <stefano.stabellini@eu.citrix.com>
Fri, 25 Feb 2011 16:43:09 +0000 (16:43 +0000)
commit552717231e50b478dfd19d63fd97879476ae051d
tree6ed6a314b8b4e2ee266e33fdf450c48704df5cbc
parente057a4b6e0eb6701f6ec923be2075d4984cef51a
xen: do not respond to unknown xenstore control requests

The PV xenbus control/shutdown node is written by the toolstack as a
request to the guest to perform a particular action (shutdown, reboot,
suspend etc). The guest is expected to acknowledge that it will
complete a request by clearing the control node.

Previously it would acknowledge any request, even if it did not know
what to do with it. Specifically in the case where CONFIG_PM_SLEEP is
not enabled the kernel would acknowledge a suspend request even though
it was not actually going to do anything.

Instead make the kernel only acknowledge requests if it is actually
going to do something with it. This will improve the toolstack's
ability to diagnose and deal with failures.

Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
drivers/xen/manage.c