fscrypt: use ENOKEY when file cannot be created w/o key
authorEric Biggers <ebiggers@google.com>
Mon, 5 Dec 2016 19:12:44 +0000 (11:12 -0800)
committerTheodore Ts'o <tytso@mit.edu>
Sat, 31 Dec 2016 21:26:20 +0000 (16:26 -0500)
commit54475f531bb8d7078f63c159e5e0615d486c498c
treece3392249747414ad787dcffa1f2b919aff5f10c
parent42d97eb0ade31e1bc537d086842f5d6e766d9d51
fscrypt: use ENOKEY when file cannot be created w/o key

As part of an effort to clean up fscrypt-related error codes, make
attempting to create a file in an encrypted directory that hasn't been
"unlocked" fail with ENOKEY.  Previously, several error codes were used
for this case, including ENOENT, EACCES, and EPERM, and they were not
consistent between and within filesystems.  ENOKEY is a better choice
because it expresses that the failure is due to lacking the encryption
key.  It also matches the error code returned when trying to open an
encrypted regular file without the key.

I am not aware of any users who might be relying on the previous
inconsistent error codes, which were never documented anywhere.

This failure case will be exercised by an xfstest.

Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
fs/crypto/fname.c
fs/ext4/ialloc.c
fs/ext4/namei.c
fs/f2fs/dir.c
fs/f2fs/namei.c