ixgbe: fix link down initial state
authorJesse Brandeburg <jesse.brandeburg@intel.com>
Fri, 17 Apr 2009 20:44:27 +0000 (20:44 +0000)
committerDavid S. Miller <davem@davemloft.net>
Mon, 20 Apr 2009 09:00:37 +0000 (02:00 -0700)
commit5438646724c34c2180664a57f862a1da8dd21db1
tree37a5dced3dd45c5cedd5752490649212b12e1220
parent3ef8e4e9e4d18910cd03dcd481a5dced437b83cf
ixgbe: fix link down initial state

As reported by Andrew Lutomirski <amluto@gmail.com>

All the intel wired ethernet drivers were calling netif_carrier_off
and netif_stop_queue (or variants) before calling register_netdevice

This is incorrect behavior as was pointed out by davem, and causes
ifconfig and friends to report a strange state before first link
after the driver was loaded, since without a netif_carrier_off, the stack
assumes carrier_on, but before register_netdev, netlink messages are not
sent out telling link state.

This apparently confused *some* versions of networkmanager.

Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Reported-by: Andrew Lutomirski <amluto@gmail.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ixgbe/ixgbe_main.c