[9610][ERD] drivers: muic: fix prevent CID 237151
authorKim Taejeong <tj.kim@samsung.com>
Tue, 28 Aug 2018 01:01:52 +0000 (10:01 +0900)
committerhskang <hs1218.kang@samsung.com>
Thu, 30 Aug 2018 10:58:39 +0000 (19:58 +0900)
commit5222132625f5b9575f0d7759099cddde98411d31
treefc6c353fd87c0fc19da41623b20020f28d1ccb5c
parent0357ae340dc808cc5c9c84cb4c4d013f931ad966
[9610][ERD] drivers: muic: fix prevent CID 237151

- Fix problem of dereference before null check.
- System comment :

1529 static irqreturn_t s2mu004_muic_attach_isr(int irq, void *data)
1530 {
1531         struct s2mu004_muic_data *muic_data = data;
/* deref_ptr: Directly dereferencing pointer muic_data. */
1532         struct muic_platform_data *muic_pdata = muic_data->pdata;
1533         int ret = 0;
1534
/* CID 237151 (#1 of 1): Dereference before null check (REVERSE_INULL)
 * check_after_deref: Null-checking muic_data suggests that it may be null,
 * but it has already been dereferenced on all paths leading to the check.
 */
1535         if (muic_data == NULL || muic_pdata == NULL) {
1536                 pr_err("%s, data NULL\n", __func__);
1537                 return IRQ_NONE;
1538         }

Change-Id: Id83cc8e3994b6f92946a440609b53f6f668b22e8
Signed-off-by: Kim Taejeong <tj.kim@samsung.com>
drivers/muic/s2mu004-muic.c