jbd2: fix dbench4 performance regression for 'nobarrier' mounts
authorJan Kara <jack@suse.cz>
Sun, 30 Apr 2017 01:07:30 +0000 (21:07 -0400)
committerTheodore Ts'o <tytso@mit.edu>
Sun, 30 Apr 2017 01:07:30 +0000 (21:07 -0400)
commit5052b069acf73866d00077d8bc49983c3ee903e5
tree5822040784b621dbb32ae4b0a3e2f86586bdb1c3
parentc52c47e4b4fbe4284602fc2ccbfc4a4d8dc05b49
jbd2: fix dbench4 performance regression for 'nobarrier' mounts

Commit b685d3d65ac7 "block: treat REQ_FUA and REQ_PREFLUSH as
synchronous" removed REQ_SYNC flag from WRITE_FUA implementation. Since
JBD2 strips REQ_FUA and REQ_FLUSH flags from submitted IO when the
filesystem is mounted with nobarrier mount option, journal superblock
writes ended up being async writes after this patch and that caused
heavy performance regression for dbench4 benchmark with high number of
processes. In my test setup with HP RAID array with non-volatile write
cache and 32 GB ram, dbench4 runs with 8 processes regressed by ~25%.

Fix the problem by making sure journal superblock writes are always
treated as synchronous since they generally block progress of the
journalling machinery and thus the whole filesystem.

Fixes: b685d3d65ac791406e0dfd8779cc9b3707fea5a3
CC: stable@vger.kernel.org
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
fs/jbd2/journal.c