iomap: report collisions between directio and buffered writes to userspace
authorDarrick J. Wong <darrick.wong@oracle.com>
Mon, 8 Jan 2018 18:41:39 +0000 (10:41 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 27 Apr 2019 07:35:41 +0000 (09:35 +0200)
commit4fa17fc730ba3b7f0cb69937df919a7a226067be
tree7c83dff86db7d9ddf798fb82df0374e918443b9a
parentc5e44540ca312c4bbaafb1950c825a930c9adfdf
iomap: report collisions between directio and buffered writes to userspace

commit 5a9d929d6e13278df62bd9e3d3ceae8c87ad1eea upstream.

If two programs simultaneously try to write to the same part of a file
via direct IO and buffered IO, there's a chance that the post-diowrite
pagecache invalidation will fail on the dirty page.  When this happens,
the dio write succeeded, which means that the page cache is no longer
coherent with the disk!

Programs are not supposed to mix IO types and this is a clear case of
data corruption, so store an EIO which will be reflected to userspace
during the next fsync.  Replace the WARN_ON with a ratelimited pr_crit
so that the developers have /some/ kind of breadcrumb to track down the
offending program(s) and file(s) involved.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Liu Bo <bo.li.liu@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Zubin Mithra <zsm@chromium.org>
fs/direct-io.c
fs/iomap.c
include/linux/fs.h