tcm_vhost: Use vq->private_data to indicate if the endpoint is setup
authorAsias He <asias@redhat.com>
Wed, 3 Apr 2013 06:17:37 +0000 (14:17 +0800)
committerNicholas Bellinger <nab@linux-iscsi.org>
Mon, 8 Apr 2013 21:07:00 +0000 (14:07 -0700)
commit4f7f46d32c9875004fae1d57ae3c02cc2e6cd6a3
tree5e2631d1353d75568af40862dc1c3014c79a0a4e
parentaf0d9187f66db2711f94dc20d5a06ec9ba5845b3
tcm_vhost: Use vq->private_data to indicate if the endpoint is setup

Currently, vs->vs_endpoint is used indicate if the endpoint is setup or
not. It is set or cleared in vhost_scsi_set_endpoint() or
vhost_scsi_clear_endpoint() under the vs->dev.mutex lock. However, when
we check it in vhost_scsi_handle_vq(), we ignored the lock.

Instead of using the vs->vs_endpoint and the vs->dev.mutex lock to
indicate the status of the endpoint, we use per virtqueue
vq->private_data to indicate it. In this way, we can only take the
vq->mutex lock which is per queue and make the concurrent multiqueue
process having less lock contention. Further, in the read side of
vq->private_data, we can even do not take the lock if it is accessed in
the vhost worker thread, because it is protected by "vhost rcu".

(nab: Do s/VHOST_FEATURES/~VHOST_SCSI_FEATURES)

Signed-off-by: Asias He <asias@redhat.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
drivers/vhost/tcm_vhost.c