clk: sunxi: fix uninitialized access
authorArnd Bergmann <arnd@arndb.de>
Wed, 23 Aug 2017 14:39:27 +0000 (16:39 +0200)
committerStephen Boyd <sboyd@codeaurora.org>
Thu, 31 Aug 2017 05:39:49 +0000 (22:39 -0700)
commit4e903450bcb9a6bc90733b981d7cb8b3c4996a0e
treeaef081a4148ff1173cb5464b2b889b4952110f73
parent2c606871f3d8e3cfd4a079081a7cd9aabdbba99a
clk: sunxi: fix uninitialized access

gcc-8 reports an uninitialized variable access in a code path
that we would see with incorrect DTB input:

drivers/clk/sunxi/clk-sun8i-bus-gates.c: In function 'sun8i_h3_bus_gates_init':
drivers/clk/sunxi/clk-sun8i-bus-gates.c:85:27: error: 'clk_parent' may be used uninitialized in this function [-Werror=maybe-uninitialized]

This works around by skipping invalid input and printing a warning
instead if it ever happens. The problem was apparently part of the
initiali driver submission, but older compilers don't notice it.

Fixes: ab6e23a4e388 ("clk: sunxi: Add H3 clocks support")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
drivers/clk/sunxi/clk-sun8i-bus-gates.c