hwmon: (mcp3021) Fix broken output scaling
authorStevens, Nick <Nick.Stevens@digi.com>
Wed, 1 Jul 2015 16:07:41 +0000 (16:07 +0000)
committerDanny Wood <danwood76@gmail.com>
Tue, 29 Jan 2019 13:09:25 +0000 (13:09 +0000)
commit4d661469ca600886e74d8bb84cac4475465828a2
tree6a63b9f989af2c60b4abbe695c831fd25f4cab8f
parentbb7ae207758a1d51c3bbf00d8b967b7387291afe
hwmon: (mcp3021) Fix broken output scaling

commit 347d7e45bd09ce09cbc30d5cea9de377eb22f55c upstream.

The mcp3021 scaling code is dividing the VDD (full-scale) value in
millivolts by the A2D resolution to obtain the scaling factor. When VDD
is 3300mV (the standard value) and the resolution is 12-bit (4096
divisions), the result is a scale factor of 3300/4096, which is always
one.  Effectively, the raw A2D reading is always being returned because
no scaling is applied.

This patch fixes the issue and simplifies the register-to-volts
calculation, removing the unneeded "output_scale" struct member.

Signed-off-by: Nick Stevens <Nick.Stevens@digi.com>
[Guenter Roeck: Dropped unnecessary value check]
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/hwmon/mcp3021.c