ACPI / SBS: Fix rare oops when removing modules
authorRonald Tschalär <ronald@innovation.ch>
Mon, 1 Oct 2018 02:53:13 +0000 (19:53 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 24 Nov 2019 07:23:19 +0000 (08:23 +0100)
commit4b9d1ab7112cfe9c3011acb661d98bad6c15a6dd
tree407d6da11bd3d4a3ea0a34d2f2750b8b01343e1c
parent3dc925644961b2e71ee5c6a8f10c11bd5443290e
ACPI / SBS: Fix rare oops when removing modules

[ Upstream commit 757c968c442397f1249bb775a7c8c03842e3e0c7 ]

There was a small race when removing the sbshc module where
smbus_alarm() had queued acpi_smbus_callback() for deferred execution
but it hadn't been run yet, so that when it did run hc had been freed
and the module unloaded, resulting in an invalid paging request.

A similar race existed when removing the sbs module with regards to
acpi_sbs_callback() (which is called from acpi_smbus_callback()).

We therefore need to ensure no callbacks are pending or executing before
the cleanups are done and the modules are removed.

Signed-off-by: Ronald Tschalär <ronald@innovation.ch>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/acpi/osl.c
drivers/acpi/sbshc.c