net: bcm63xx: avoid referencing uninitialized variable
authorArnd Bergmann <arnd@arndb.de>
Mon, 17 Oct 2016 22:16:08 +0000 (00:16 +0200)
committerDavid S. Miller <davem@davemloft.net>
Tue, 18 Oct 2016 18:20:36 +0000 (14:20 -0400)
commit4b75ca5a7a9e01dda3ea70bc17b1826fd679af61
tree8314c3c865dd117e007705dba990698d2ce9534e
parent41ee9c557ef5de992843b6dac35a199e651525cf
net: bcm63xx: avoid referencing uninitialized variable

gcc found a reference to an uninitialized variable in the error handling
of bcm_enet_open, introduced by a recent cleanup:

drivers/net/ethernet/broadcom/bcm63xx_enet.c: In function 'bcm_enet_open'
drivers/net/ethernet/broadcom/bcm63xx_enet.c:1129:2: warning: 'phydev' may be used uninitialized in this function [-Wmaybe-uninitialized]

This makes the use of that variable conditional, so we only reference it
here after it has been used before. Unlike my normal patches, I have not
build-tested this one, as I don't currently have mips test in my
randconfig setup.

Fixes: 625eb8667d6f ("net: ethernet: broadcom: bcm63xx: use phydev from struct net_device")
Cc: Philippe Reynes <tremyfr@gmail.com>
Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/broadcom/bcm63xx_enet.c