projects / GitHub / moto-9609 / android_kernel_motorola_exynos9610.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 13e676b) | patch
gpio: generic: fix signedness bug found by cppcheck
authorLinus Walleij <linus.walleij@linaro.org>
Tue, 5 Jan 2016 10:13:28 +0000 (11:13 +0100)
committerLinus Walleij <linus.walleij@linaro.org>
Tue, 5 Jan 2016 10:13:28 +0000 (11:13 +0100)
commit4b63739efabc93d67d2b6812dd0cd41358fadf29
tree980fce8217893a92b5f276e7b088915378d822cbtree | snapshot (tar.gz zip)
parent13e676be085341c1161c3daf535e98ec6d5d6e3ccommit | diff
gpio: generic: fix signedness bug found by cppcheck

cppcheck reports this:

(style) int result is returned as long value. If the return
value is long to avoid loss of information, then you have
loss of information.

This can be fixed with (1UL << pin) but that is the same
as using <linux/bitops.h> that already use 1UL so take
this approach.

Reported-by: David Binderman <dcb314@hotmail.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/gpio/gpio-generic.c diff | blob | blame | history