vsock: prevent unnecessary refcnt inc for nonblocking connect
authorEiichi Tsukata <eiichi.tsukata@nutanix.com>
Tue, 9 Nov 2021 00:15:02 +0000 (00:15 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 26 Nov 2021 10:48:39 +0000 (11:48 +0100)
commit472970a3b5a6483a46365fffc4f849222df7e53d
treed4f0c9408bf95026e182c0b22f34fb4be83f6f55
parent4a85c43a03d41a6cf5735ec406b5e1e245db2238
vsock: prevent unnecessary refcnt inc for nonblocking connect

[ Upstream commit c7cd82b90599fa10915f41e3dd9098a77d0aa7b6 ]

Currently vosck_connect() increments sock refcount for nonblocking
socket each time it's called, which can lead to memory leak if
it's called multiple times because connect timeout function decrements
sock refcount only once.

Fixes it by making vsock_connect() return -EALREADY immediately when
sock state is already SS_CONNECTING.

Fixes: d021c344051a ("VSOCK: Introduce VM Sockets")
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
Signed-off-by: Eiichi Tsukata <eiichi.tsukata@nutanix.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/vmw_vsock/af_vsock.c