md/bitmap: disable bitmap_resize for file-backed bitmaps.
authorNeilBrown <neilb@suse.com>
Thu, 31 Aug 2017 00:23:25 +0000 (10:23 +1000)
committerDanny Wood <danwood76@gmail.com>
Tue, 29 Jan 2019 13:18:18 +0000 (13:18 +0000)
commit4538b6006b13d69d4ddd0c68113cd40808cbd42c
tree9c2bed5588c134d5bd1d76567806f40da7bd45d1
parentadca1bfbd90db39222cc3d609a8a3eeda74cdc1a
md/bitmap: disable bitmap_resize for file-backed bitmaps.

commit e8a27f836f165c26f867ece7f31eb5c811692319 upstream.

bitmap_resize() does not work for file-backed bitmaps.
The buffer_heads are allocated and initialized when
the bitmap is read from the file, but resize doesn't
read from the file, it loads from the internal bitmap.
When it comes time to write the new bitmap, the bh is
non-existent and we crash.

The common case when growing an array involves making the array larger,
and that normally means making the bitmap larger.  Doing
that inside the kernel is possible, but would need more code.
It is probably easier to require people who use file-backed
bitmaps to remove them and re-add after a reshape.

So this patch disables the resizing of arrays which have
file-backed bitmaps.  This is better than crashing.

Reported-by: Zhilong Liu <zlliu@suse.com>
Fixes: d60b479d177a ("md/bitmap: add bitmap_resize function to allow bitmap resizing.")
Cc: stable@vger.kernel.org (v3.5+).
Signed-off-by: NeilBrown <neilb@suse.com>
Signed-off-by: Shaohua Li <shli@fb.com>
Signed-off-by: Willy Tarreau <w@1wt.eu>
drivers/md/bitmap.c