Revert "netfilter: conntrack: fix race in __nf_conntrack_confirm against get_next_corpse"
authorPablo Neira <pablo@netfilter.org>
Tue, 25 Nov 2014 18:54:47 +0000 (19:54 +0100)
committerDavid S. Miller <davem@davemloft.net>
Tue, 25 Nov 2014 19:14:51 +0000 (14:14 -0500)
commit43612d7c04f1a4f5e60104143918fcdf018b66ee
treecde0881345eea4c43ad76670e001f85271806604
parent814f7d115ec6348070b57e08851037fce486e16b
Revert "netfilter: conntrack: fix race in __nf_conntrack_confirm against get_next_corpse"

This reverts commit 5195c14c8b27cc0b18220ddbf0e5ad3328a04187.

If the conntrack clashes with an existing one, it is left out of
the unconfirmed list, thus, crashing when dropping the packet and
releasing the conntrack since golden rule is that conntracks are
always placed in any of the existing lists for traceability reasons.

Reported-by: Daniel Borkmann <dborkman@redhat.com>
Fixes: https://bugzilla.kernel.org/show_bug.cgi?id=88841
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/netfilter/nf_conntrack_core.c