tcp: Document use of undefined variable.
authorAlan Cox <alan@linux.intel.com>
Wed, 19 Sep 2012 14:46:06 +0000 (15:46 +0100)
committerDavid S. Miller <davem@davemloft.net>
Thu, 20 Sep 2012 21:29:36 +0000 (17:29 -0400)
commit4308fc58dceda40fac8a8d9c05b7cfba0a6bbed3
treeaddfb9116bc2de864d020bcda4c478aa1c3edf7b
parentbb68b64724a4fd6b93d83b39aeffa4aadb2562fc
tcp: Document use of undefined variable.

Both tcp_timewait_state_process and tcp_check_req use the same basic
construct of

struct tcp_options received tmp_opt;
tmp_opt.saw_tstamp = 0;

then call

tcp_parse_options

However if they are fed a frame containing a TCP_SACK then tbe code
behaviour is undefined because opt_rx->sack_ok is undefined data.

This ought to be documented if it is intentional.

Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/tcp_minisocks.c