mfd: menelaus: Fix error return code
authorJulia Lawall <julia.lawall@lip6.fr>
Thu, 21 Aug 2014 12:06:06 +0000 (07:06 -0500)
committerLee Jones <lee.jones@linaro.org>
Fri, 26 Sep 2014 07:15:41 +0000 (08:15 +0100)
commit42a71ef97b7ac31ae8f929c36048fec5cd201a49
tree86ec3624c4f051eb82df71210df764f6e4590203
parent2a3377ee2d8ca15ba21caf1d420cfeaf3ba4390a
mfd: menelaus: Fix error return code

Convert a zero return value on error to a negative one, as returned
elsewhere in the function.

Additionally, converted 1 << 7 to BIT(7) at the suggestion of Lee Jones.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
 { ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
    when != &ret
*if(...)
{
  ... when != ret = e2
      when forall
 return ret;
}

// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
drivers/mfd/menelaus.c