NFSv4: Fix a NULL pointer dereference in pnfs_mark_matching_lsegs_return()
authorAnna Schumaker <Anna.Schumaker@Netapp.com>
Wed, 19 May 2021 16:54:51 +0000 (12:54 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 3 Jun 2021 06:36:12 +0000 (08:36 +0200)
commit42637ca25c7d7b5a92804a679af5192e8c1a9f48
treea3b1c4875e4503d7396165deb2abbe46db1a5c8c
parent2c2fb2df46ea866b49fea5ec7112ec3cd4896c74
NFSv4: Fix a NULL pointer dereference in pnfs_mark_matching_lsegs_return()

commit a421d218603ffa822a0b8045055c03eae394a7eb upstream.

Commit de144ff4234f changes _pnfs_return_layout() to call
pnfs_mark_matching_lsegs_return() passing NULL as the struct
pnfs_layout_range argument. Unfortunately,
pnfs_mark_matching_lsegs_return() doesn't check if we have a value here
before dereferencing it, causing an oops.

I'm able to hit this crash consistently when running connectathon basic
tests on NFS v4.1/v4.2 against Ontap.

Fixes: de144ff4234f ("NFSv4: Don't discard segments marked for return in _pnfs_return_layout()")
Cc: stable@vger.kernel.org
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/nfs/pnfs.c