selinux: conditional expression type validation was off-by-one
authorVesa-Matti Kari <vmkari@cc.helsinki.fi>
Wed, 6 Aug 2008 15:24:51 +0000 (18:24 +0300)
committerJames Morris <jmorris@namei.org>
Wed, 6 Aug 2008 22:56:16 +0000 (08:56 +1000)
commit421fae06be9e0dac45747494756b3580643815f9
tree8b390e53636092477c82304b7f7f10524df6fd1b
parent15446235367fa4a621ff5abfa4b6ebbe25b33763
selinux: conditional expression type validation was off-by-one

expr_isvalid() in conditional.c was off-by-one and allowed
invalid expression type COND_LAST. However, it is this header file
that needs to be fixed. That way the if-statement's disjunction's
second component reads more naturally, "if expr type is greater than
the last allowed value" ( rather than using ">=" in conditional.c):

  if (expr->expr_type <= 0 || expr->expr_type > COND_LAST)

Signed-off-by: Vesa-Matti Kari <vmkari@cc.helsinki.fi>
Signed-off-by: James Morris <jmorris@namei.org>
security/selinux/ss/conditional.h