af_packet: don't pass empty blocks for PACKET_V3
authorAlexander Drozdov <al.drozdov@gmail.com>
Tue, 24 Feb 2015 05:18:28 +0000 (08:18 +0300)
committerDavid S. Miller <davem@davemloft.net>
Tue, 24 Feb 2015 21:08:42 +0000 (16:08 -0500)
commit41a50d621a321b4c15273cc1b5ed41437f4acdfb
treebbd899b61dfd05a872a0f6e3e6023cee9ead40f3
parent4e10fd5b4a7f4100007147558c304da3e73b25cf
af_packet: don't pass empty blocks for PACKET_V3

Before da413eec729d ("packet: Fixed TPACKET V3 to signal poll when block is
closed rather than every packet") poll listening for an af_packet socket was
not signaled if there was no packets to process. After the patch poll is
signaled evety time when block retire timer expires. That happens because
af_packet closes the current block on timeout even if the block is empty.

Passing empty blocks to the user not only wastes CPU but also wastes ring
buffer space increasing probability of packets dropping on small timeouts.

Signed-off-by: Alexander Drozdov <al.drozdov@gmail.com>
Cc: Dan Collins <dan@dcollins.co.nz>
Cc: Willem de Bruijn <willemb@google.com>
Cc: Guy Harris <guy@alum.mit.edu>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/packet/af_packet.c