smack: use GFP_NOFS while holding inode_smack::smk_lock
authorEric Biggers <ebiggers@google.com>
Thu, 22 Aug 2019 05:54:41 +0000 (22:54 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 7 Oct 2019 16:55:22 +0000 (18:55 +0200)
commit416a5d0346696d7d70ffeb5e51a911e6709c6575
treefd82c2933088166f823ad17ddd2e695a41fb44a3
parentca2cf05447866c4653243bfe3ce4d1114eaee953
smack: use GFP_NOFS while holding inode_smack::smk_lock

commit e5bfad3d7acc5702f32aafeb388362994f4d7bd0 upstream.

inode_smack::smk_lock is taken during smack_d_instantiate(), which is
called during a filesystem transaction when creating a file on ext4.
Therefore to avoid a deadlock, all code that takes this lock must use
GFP_NOFS, to prevent memory reclaim from waiting for the filesystem
transaction to complete.

Reported-by: syzbot+0eefc1e06a77d327a056@syzkaller.appspotmail.com
Cc: stable@vger.kernel.org
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Casey Schaufler <casey@schaufler-ca.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
security/smack/smack_access.c
security/smack/smack_lsm.c