ACPI / sysfs: fix error code in get_status()
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 5 May 2016 13:23:04 +0000 (16:23 +0300)
committerWilly Tarreau <w@1wt.eu>
Wed, 19 Oct 2016 22:46:31 +0000 (00:46 +0200)
commit40772621b96c5c05e3cb28d60f43bd77f963cabd
treed29f4e7cda4239c21274f00a2ce0f693506babc5
parent479c12a03b99cab376b02b28aab81ea450f2137a
ACPI / sysfs: fix error code in get_status()

commit f18ebc211e259d4f591e39e74b2aa2de226c9a1d upstream.

The problem with ornamental, do-nothing gotos is that they lead to
"forgot to set the error code" bugs.  We should be returning -EINVAL
here but we don't.  It leads to an uninitalized variable in
counter_show():

    drivers/acpi/sysfs.c:603 counter_show()
    error: uninitialized symbol 'status'.

Fixes: 1c8fce27e275 (ACPI: introduce drivers/acpi/sysfs.c)
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Willy Tarreau <w@1wt.eu>
drivers/acpi/sysfs.c