UPSTREAM: filemap: add a comment about FAULT_FLAG_RETRY_NOWAIT behavior
authorLinus Torvalds <torvalds@linux-foundation.org>
Fri, 15 Mar 2019 18:26:07 +0000 (11:26 -0700)
committerMinchan Kim <minchan@google.com>
Fri, 29 Mar 2019 06:08:27 +0000 (15:08 +0900)
commit403d0082901ced8df24a09383ab45a0476264118
tree29f84950823e654cc2e93d5c8e48ab1a909ba6ad
parentce3ca1406bce18270c605f475b648f2e24be1e81
UPSTREAM: filemap: add a comment about FAULT_FLAG_RETRY_NOWAIT behavior

I thought Josef Bacik's patch to drop the mmap_sem was buggy, because
when looking at the error cases, there was one case where we returned
VM_FAULT_RETRY without actually dropping the mmap_sem.

Josef had to explain to me (using small words) that yes, that's actually
what we're supposed to do, and his patch was correct.  Which not only
convinced me he knew what he was doing and I should stop arguing with
him, but also that I should add a comment to the case I was confused
about.

Bug: 124328118
Change-Id: I968005b3673da3adad843c2660111e9a70f98c26
Patiently-pointed-out-by: Josef Bacik <josef@toxicpanda.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
(cherry picked from commit 8b0f9fa2e02dc95216577c3387b0707c5f60fbaf)
Signed-off-by: Minchan Kim <minchan@google.com>
mm/filemap.c