drm/i915: Don't WARN nor handle unexpected hpd interrupts on gmch platforms
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Thu, 24 Apr 2014 10:03:17 +0000 (12:03 +0200)
committerJani Nikula <jani.nikula@intel.com>
Fri, 25 Apr 2014 13:01:14 +0000 (16:01 +0300)
commit3ff04a160a891e56cdcee5c198d4c764d1c8c78b
treef9ebb8de65449f7ac06286921551eaa3f8133ff6
parent0f9dc59db6abc475dc23afc077fabbc606b8830f
drm/i915: Don't WARN nor handle unexpected hpd interrupts on gmch platforms

The status bits are unconditionally set, the control bits only enable
the actual interrupt generation. Which means if we get some random
other interrupts we'll bogusly complain about them.

So restrict the WARN to platforms with a sane hotplug interrupt
handling scheme. And even more important also don't attempt to process
the hpd bit since we've detected a storm already. Instead just clear
the bit silently.

This WARN has been introduced in

commit b8f102e8bf71cacf33326360fdf9dcfd1a63925b
Author: Egbert Eich <eich@suse.de>
Date:   Fri Jul 26 14:14:24 2013 +0200

    drm/i915: Add messages useful for HPD storm detection debugging (v2)

before that we silently handled the hpd event and so partially
defeated the storm detection.

v2: Pimp commit message (Jani)

Cc: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Egbert Eich <eich@suse.de>
Cc: bitlord <bitlord0xff@gmail.com>
Reported-by: bitlord <bitlord0xff@gmail.com>
Cc: stable@vger.kernel.org
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
drivers/gpu/drm/i915/i915_irq.c