svcrdma: Scrub BUG_ON() and WARN_ON() call sites
authorChuck Lever <chuck.lever@oracle.com>
Tue, 13 Jan 2015 16:03:03 +0000 (11:03 -0500)
committerJ. Bruce Fields <bfields@redhat.com>
Thu, 15 Jan 2015 20:01:45 +0000 (15:01 -0500)
commit3fe04ee9f91084e7e6e999b09b8b15bcf97375e8
treee6114e9643a87905b704c7103252e181043432ff
parent2397aa8b515f7bd77c8d5698170b6a98fdd6721c
svcrdma: Scrub BUG_ON() and WARN_ON() call sites

Current convention is to avoid using BUG_ON() in places where an
oops could cause complete system failure.

Replace BUG_ON() call sites in svcrdma with an assertion error
message and allow execution to continue safely.

Some BUG_ON() calls are removed because they have never fired in
production (that we are aware of).

Some WARN_ON() calls are also replaced where a back trace is not
helpful; e.g., in a workqueue task.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Reviewed-by: Steve Wise <swise@opengridcomputing.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
net/sunrpc/xprtrdma/svc_rdma_recvfrom.c
net/sunrpc/xprtrdma/svc_rdma_sendto.c
net/sunrpc/xprtrdma/svc_rdma_transport.c