UPSTREAM: drivers/block/zram/zram_drv.c: fix bug storing backing_dev
authorPeter Kalauskas <peskal@google.com>
Wed, 22 Aug 2018 04:54:02 +0000 (21:54 -0700)
committerMichael Benedict <michaelbt@live.com>
Fri, 30 Aug 2019 07:42:55 +0000 (17:42 +1000)
commit3f742bdd45150191982199074aa17eeee5658881
tree60d82adce5d3445478588fc9e4106cf696da2981
parentd102f71cbf69f3a79506cabe8a2daabb63c422a8
UPSTREAM: drivers/block/zram/zram_drv.c: fix bug storing backing_dev

The call to strlcpy in backing_dev_store is incorrect. It should take
the size of the destination buffer instead of the size of the source
buffer.  Additionally, ignore the newline character (\n) when reading
the new file_name buffer. This makes it possible to set the backing_dev
as follows:

echo /dev/sdX > /sys/block/zram0/backing_dev

The reason it worked before was the fact that strlcpy() copies 'len - 1'
bytes, which is strlen(buf) - 1 in our case, so it accidentally didn't
copy the trailing new line symbol.  Which also means that "echo -n
/dev/sdX" most likely was broken.

Signed-off-by: Peter Kalauskas <peskal@google.com>
Link: http://lkml.kernel.org/r/20180813061623.GC64836@rodete-desktop-imager.corp.google.com
Acked-by: Minchan Kim <minchan@kernel.org>
Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Cc: <stable@vger.kernel.org> [4.14+]
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
(cherry picked from commit c8bd134a4bddafe5917d163eea73873932c15e83)
Signed-off-by: Peter Kalauskas <peskal@google.com>
Bug: 112488418
Change-Id: I0a0d602b61169ae9adc8f89914ce4e30cc10e191
drivers/block/zram/zram_drv.c