btrfs: fix ulist leaks in error paths of qgroup self tests
authorFilipe Manana <fdmanana@suse.com>
Tue, 1 Nov 2022 16:15:39 +0000 (16:15 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 10 Nov 2022 14:47:21 +0000 (15:47 +0100)
commit3f58283d83a588ff5da62fc150de19e798ed2ec2
treeeb812aefd55527a89a7e9696817606c7a7ee78a3
parentb1dc9019bb5f89abae85645de1a2dd4830c1f8e9
btrfs: fix ulist leaks in error paths of qgroup self tests

[ Upstream commit d37de92b38932d40e4a251e876cc388f9aee5f42 ]

In the test_no_shared_qgroup() and test_multiple_refs() qgroup self tests,
if we fail to add the tree ref, remove the extent item or remove the
extent ref, we are returning from the test function without freeing the
"old_roots" ulist that was allocated by the previous calls to
btrfs_find_all_roots(). Fix that by calling ulist_free() before returning.

Fixes: 442244c96332 ("btrfs: qgroup: Switch self test to extent-oriented qgroup mechanism.")
Signed-off-by: Filipe Manana <fdmanana@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
fs/btrfs/tests/qgroup-tests.c