powercap: intel_rapl: fix UBSAN shift-out-of-bounds issue
authorChao Qin <chao.qin@intel.com>
Tue, 20 Sep 2022 06:08:26 +0000 (14:08 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 26 Oct 2022 11:17:08 +0000 (13:17 +0200)
commit3eb0ba70376f6ee40fa843fc9cee49269370b0b3
tree3247810b054fb48233ed5ff8385eb6e85193861c
parentd6ab85b25f35c64ee41add8565dad3f6295a4ce8
powercap: intel_rapl: fix UBSAN shift-out-of-bounds issue

[ Upstream commit 2d93540014387d1c73b9ccc4d7895320df66d01b ]

When value < time_unit, the parameter of ilog2() will be zero and
the return value is -1. u64(-1) is too large for shift exponent
and then will trigger shift-out-of-bounds:

shift exponent 18446744073709551615 is too large for 32-bit type 'int'
Call Trace:
 rapl_compute_time_window_core
 rapl_write_data_raw
 set_time_window
 store_constraint_time_window_us

Signed-off-by: Chao Qin <chao.qin@intel.com>
Acked-by: Zhang Rui <rui.zhang@intel.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/powercap/intel_rapl.c