[SCSI] mptsas: fixed hot-removal processing
authorKei Tokunaga <tokunaga.keiich@jp.fujitsu.com>
Wed, 7 Apr 2010 10:17:24 +0000 (19:17 +0900)
committerJames Bottomley <James.Bottomley@suse.de>
Tue, 27 Jul 2010 17:03:50 +0000 (12:03 -0500)
commit3e84beba608dee5a7c7711a3503eb2f335c78fca
tree58dc95fa9acb677e84c770ddf00cf7eaaa4321a0
parentcb237ef7a45f22373575b2d2ad2d06f7d38d6bce
[SCSI] mptsas: fixed hot-removal processing

This patch fixes mptsas disk hot-removal processing.  The
hot-removal processing doesn't complete because of this condition.

  drivers/message/fusion/mptsas.c:
  mptsas_taskmgmt_complete()

  if ((mptsas_find_vtarget(ioc, channel, id)) && !ioc->fw_events_off)
    mptsas_queue_device_delete(...);

mptsas_queue_device_delete(), which must be called for
hot-removal, never gets called because mptsas_find_vtarget()
always returns 0 here.  At that time, the vtarget has already
been freed in mptsas_target_destroy(), and also the scsi_device
has been marked as SDEV_DEL.

As a result of the issue, port deletion functions won't get
called and the device ends up being in an incomplete state.
(Some data structures and sysfs entries, which should be
removed in hot-removal, remain.)  One side effect of this is
that a hot-addition of the device (bringing the device back
on) fails.

This patch just removes mptsas_find_vtarget() from the if-state
condition.

Signed-off-by: Kei Tokunaga <tokunaga.keiich@jp.fujitsu.com>
Acked-by: "Desai, Kashyap" <Kashyap.Desai@lsi.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
drivers/message/fusion/mptsas.c