mac80211: fix tx select key null pointer crash with hostapd
authorKalle Valo <kalle.valo@iki.fi>
Sat, 23 Jan 2010 18:27:14 +0000 (20:27 +0200)
committerJohn W. Linville <linville@tuxdriver.com>
Sat, 23 Jan 2010 21:47:00 +0000 (16:47 -0500)
commit3b43a18743421cccd33902e29016fa49b2d52dbb
treeeaaab22a16260625854a51076fe64d5787e98ac4
parentf12553ebe045a8a40ab33fa500fb57d10706e226
mac80211: fix tx select key null pointer crash with hostapd

Pavel Roskin reported a crash in ieee80211_tx_h_select_key():

http://marc.info/?l=linux-wireless&m=126419655108528&w=2

This is a regression from patch "mac80211: move control.hw_key assignment".
Fix it as suggested by Johannes, adding an else statement to make sure
that tx->key is not accessed when it's null.

Compile-tested only.

Reported-by: Pavel Roskin <proski@gnu.org>
Cc: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: Kalle Valo <kalle.valo@iki.fi>
Tested-by: Bob Copeland <me@bobcopeland.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
net/mac80211/tx.c