PCI: acpiphp: Remove all functions even if function 0 doesn't exist
authorJiang Liu <liuj97@gmail.com>
Fri, 12 Apr 2013 05:44:18 +0000 (05:44 +0000)
committerBjorn Helgaas <bhelgaas@google.com>
Fri, 12 Apr 2013 21:38:25 +0000 (15:38 -0600)
commit3a0e40beefc20852191ed65d53e1b82d95ac11b8
tree88016bbede6794b6635d86e19c1cd09b56e295e4
parentd65eba6a7a769bb939303969267cbf1c916358f5
PCI: acpiphp: Remove all functions even if function 0 doesn't exist

Currently function disable_device() detects slot state by checking
existence of PCI function 0.  It's unreliable because the PCI device
for function 0 may be removed through the sysfs interface.  If that
happens, it will cause powering off a hotplug slot without destroying
all PCI devices.

On the other hand, it won't hurt us except wasting some computation
power if the check is removed, because all code of disable_device()
is self-protected.  So remove the check.

Signed-off-by: Jiang Liu <jiang.liu@huawei.com>
Signed-off-by: Yijing Wang <wangyijing@huawei.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Yinghai Lu <yinghai@kernel.org>
Cc: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
Cc: Toshi Kani <toshi.kani@hp.com>
drivers/pci/hotplug/acpiphp_glue.c