nfsd4: fix security flavor of NFSv4.0 callback
authorJ. Bruce Fields <bfields@redhat.com>
Thu, 16 Aug 2012 21:01:21 +0000 (17:01 -0400)
committerJ. Bruce Fields <bfields@redhat.com>
Mon, 20 Aug 2012 22:38:36 +0000 (18:38 -0400)
commit39307655a1effa8d913bba054c0e985bfaca808c
tree444839c0cc97415f931fbd24b4548d2c93a38d1a
parentd9875690d9b89a866022ff49e3fcea892345ad92
nfsd4: fix security flavor of NFSv4.0 callback

Commit d5497fc693a446ce9100fcf4117c3f795ddfd0d2 "nfsd4: move rq_flavor
into svc_cred" forgot to remove cl_flavor from the client, leaving two
places (cl_flavor and cl_cred.cr_flavor) for the flavor to be stored.
After that patch, the latter was the one that was updated, but the
former was the one that the callback used.

Symptoms were a long delay on utime().  This is because the utime()
generated a setattr which recalled a delegation, but the cb_recall was
ignored by the client because it had the wrong security flavor.

Cc: stable@vger.kernel.org
Tested-by: Jamie Heilman <jamie@audible.transient.net>
Reported-by: Jamie Heilman <jamie@audible.transient.net>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
fs/nfsd/nfs4callback.c
fs/nfsd/state.h