tick: hrtimer-broadcast: Prevent endless restarting when broadcast device is unused
authorAndreas Sandberg <andreas.sandberg@arm.com>
Fri, 24 Apr 2015 13:06:05 +0000 (13:06 +0000)
committerThomas Gleixner <tglx@linutronix.de>
Tue, 5 May 2015 13:34:21 +0000 (15:34 +0200)
commit38d23a6cc16c02f7b0c920266053f340b5601735
tree1a6a0ed779a204818bdd47bc53b7b91f3a25485d
parent781978e6e156101209f62b9ebc8783b70ef248de
tick: hrtimer-broadcast: Prevent endless restarting when broadcast device is unused

The hrtimer callback in the hrtimer's tick broadcast code sometimes
incorrectly ends up scheduling events at the current tick causing the
kernel to hang servicing the same hrtimer forever. This typically
happens when a device is swapped out by
tick_install_broadcast_device(), which replaces the event handler with
clock_events_handle_noop() and sets the device mode to
CLOCK_EVT_MODE_UNUSED. If the timer is scheduled when this happens,
the next_event field will not be updated and the hrtimer ends up being
restarted at the current tick. To prevent this from happening, only
try to restart the hrtimer if the broadcast clock event device is in
one of the active modes and try to cancel the timer when entering the
CLOCK_EVT_MODE_UNUSED mode.

Signed-off-by: Andreas Sandberg <andreas.sandberg@arm.com>
Tested-by: Catalin Marinas <catalin.marinas@arm.com>
Acked-by: Mark Rutland <mark.rutland@arm.com>
Reviewed-by: Preeti U Murthy <preeti@linux.vnet.ibm.com>
Link: http://lkml.kernel.org/r/1429880765-5558-1-git-send-email-andreas.sandberg@arm.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
kernel/time/tick-broadcast-hrtimer.c