ANDROID: goldfish: goldfish_pipe: fix locking errors
authorGreg Hackmann <ghackmann@google.com>
Fri, 18 Nov 2016 19:09:02 +0000 (11:09 -0800)
committerGreg Hackmann <ghackmann@google.com>
Fri, 18 Nov 2016 19:28:54 +0000 (19:28 +0000)
commit37e461fc4453488c394ccdbdcb8e286c122b047a
tree031b2e7ca7146c79825625c48d90866680459679
parent5f93f3cb3ab26abd6791bc1f01e6a9db73e65536
ANDROID: goldfish: goldfish_pipe: fix locking errors

If the get_user_pages_fast() call in goldfish_pipe_read_write() failed,
it would return while still holding pipe->lock.

goldfish_pipe_read_write() later releases and tries to re-acquire
pipe->lock.  If the re-acquire call failed, goldfish_pipe_read_write()
would try unlock pipe->lock on exit anyway.

This fixes the smatch messages:

drivers/platform/goldfish/goldfish_pipe.c:392 goldfish_pipe_read_write() error: double unlock 'mutex:&pipe->lock'
drivers/platform/goldfish/goldfish_pipe.c:397 goldfish_pipe_read_write() warn: inconsistent returns 'mutex:&pipe->lock'.

Change-Id: Ifd06a76b32027ca451a001704ade0c5440ed69c4
Signed-off-by: Greg Hackmann <ghackmann@google.com>
drivers/platform/goldfish/goldfish_pipe.c