ALSA: seq: Don't handle loop timeout at snd_seq_pool_done()
authorTakashi Iwai <tiwai@suse.de>
Mon, 6 Feb 2017 14:09:48 +0000 (15:09 +0100)
committerTakashi Iwai <tiwai@suse.de>
Mon, 6 Feb 2017 14:09:48 +0000 (15:09 +0100)
commit37a7ea4a9b81f6a864c10a7cb0b96458df5310a3
tree11144552593b9656fa4cad7bde945e5bb1a5ad4a
parentd5adbfcd5f7bcc6fa58a41c5c5ada0e5c826ce2c
ALSA: seq: Don't handle loop timeout at snd_seq_pool_done()

snd_seq_pool_done() syncs with closing of all opened threads, but it
aborts the wait loop with a timeout, and proceeds to the release
resource even if not all threads have been closed.  The timeout was 5
seconds, and if you run a crazy stuff, it can exceed easily, and may
result in the access of the invalid memory address -- this is what
syzkaller detected in a bug report.

As a fix, let the code graduate from naiveness, simply remove the loop
timeout.

BugLink: http://lkml.kernel.org/r/CACT4Y+YdhDV2H5LLzDTJDVF-qiYHUHhtRaW4rbb4gUhTCQB81w@mail.gmail.com
Reported-by: Dmitry Vyukov <dvyukov@google.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/core/seq/seq_memory.c