USB: usbip: fix potential out-of-bounds write
authorIgnat Korchagin <ignat.korchagin@gmail.com>
Thu, 17 Mar 2016 18:00:29 +0000 (18:00 +0000)
committerWilly Tarreau <w@1wt.eu>
Tue, 7 Jun 2016 08:42:51 +0000 (10:42 +0200)
commit378175d0ac887f3fb4b8644152f05ccccff7e8d2
treef1ed33dfb3ecd84c8e2c22f2ff33fdf42c0dbe62
parent8a872b18df6f08c45ec89d55826ba08cd39756c3
USB: usbip: fix potential out-of-bounds write

commit b348d7dddb6c4fbfc810b7a0626e8ec9e29f7cbb upstream.

Fix potential out-of-bounds write to urb->transfer_buffer
usbip handles network communication directly in the kernel. When receiving a
packet from its peer, usbip code parses headers according to protocol. As
part of this parsing urb->actual_length is filled. Since the input for
urb->actual_length comes from the network, it should be treated as untrusted.
Any entity controlling the network may put any value in the input and the
preallocated urb->transfer_buffer may not be large enough to hold the data.
Thus, the malicious entity is able to write arbitrary data to kernel memory.

Signed-off-by: Ignat Korchagin <ignat.korchagin@gmail.com>
Cc: Sasha Levin <sasha.levin@oracle.com>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Willy Tarreau <w@1wt.eu>
drivers/staging/usbip/usbip_common.c