[SCSI] lpfc: Move a dereference below a NULL test
authorJulia Lawall <julia@diku.dk>
Tue, 16 Dec 2008 15:15:08 +0000 (16:15 +0100)
committerJames Bottomley <James.Bottomley@HansenPartnership.com>
Fri, 2 Jan 2009 16:59:38 +0000 (10:59 -0600)
commit372bd282900c2d480152622a82942b369b98d49a
treeaabeeed813e87f1f3fe6d23ea36b54d5abc925bb
parentb99b4c67db9b6dde67955b3746666505a48ec7ee
[SCSI] lpfc: Move a dereference below a NULL test

In each case, if the NULL test is necessary, then the dereference should be
moved below the NULL test.

The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@@
type T;
expression E;
identifier i,fld;
statement S;
@@

- T i = E->fld;
+ T i;
  ... when != E
      when != i
  if (E == NULL) S
+ i = E->fld;
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: James Smart <James.Smart@Emulex.Com>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
drivers/scsi/lpfc/lpfc_init.c