xfs: fix inode validity check in xfs_iflush_cluster
authorDave Chinner <dchinner@redhat.com>
Wed, 18 May 2016 03:54:22 +0000 (13:54 +1000)
committerWilly Tarreau <w@1wt.eu>
Mon, 22 Aug 2016 05:31:38 +0000 (07:31 +0200)
commit360914d619705b62f974492658e96f3d111232a8
tree5d39f1d504291b1ba6ba43f14215cf3b2cc09d5e
parent01ee4801e26c15e5bf3d0a9b563d125bbbd2ed66
xfs: fix inode validity check in xfs_iflush_cluster

commit 51b07f30a71c27405259a0248206ed4e22adbee2 upstream.

Some careless idiot(*) wrote crap code in commit 1a3e8f3 ("xfs:
convert inode cache lookups to use RCU locking") back in late 2010,
and so xfs_iflush_cluster checks the wrong inode for whether it is
still valid under RCU protection. Fix it to lock and check the
correct inode.

(*) Careless-idiot: Dave Chinner <dchinner@redhat.com>

cc: <stable@vger.kernel.org> # 3.10.x-
Discovered-by: Brain Foster <bfoster@redhat.com>
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Dave Chinner <david@fromorbit.com>
Signed-off-by: Willy Tarreau <w@1wt.eu>
fs/xfs/xfs_inode.c