lockdep: Change mark_held_locks() to check hlock->check instead of lockdep_no_validate
authorOleg Nesterov <oleg@redhat.com>
Mon, 20 Jan 2014 18:20:13 +0000 (19:20 +0100)
committerIngo Molnar <mingo@kernel.org>
Sun, 9 Feb 2014 20:18:59 +0000 (21:18 +0100)
commit34d0ed5ea7a72d5961552fb1758a94f0d3f8f3dc
tree71bb8a7c24ce1cd76a99586f119fba3f955f4c1e
parent1b5ff816cab708ba44c7d7b56b613516269eb577
lockdep: Change mark_held_locks() to check hlock->check instead of lockdep_no_validate

The __lockdep_no_validate check in mark_held_locks() adds the subtle
and (afaics) unnecessary difference between no-validate and check==0.
And this looks even more inconsistent because __lock_acquire() skips
mark_irqflags()->mark_lock() if !check.

Change mark_held_locks() to check hlock->check instead.

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Cc: Dave Jones <davej@redhat.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Paul McKenney <paulmck@linux.vnet.ibm.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Alan Stern <stern@rowland.harvard.edu>
Cc: Sasha Levin <sasha.levin@oracle.com>
Signed-off-by: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/20140120182013.GA26505@redhat.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
kernel/locking/lockdep.c