xfs: set superblock buffer type correctly
authorDave Chinner <dchinner@redhat.com>
Wed, 21 Jan 2015 22:30:23 +0000 (09:30 +1100)
committerDave Chinner <david@fromorbit.com>
Wed, 21 Jan 2015 22:30:23 +0000 (09:30 +1100)
commit3443a3bca54588f43286b725d8648d33a38c86f1
tree2360fbe8b5c4c60c31d7207174cb94d7d3fb8d33
parentfe22d552b82d7cc7de1851233ae8bef579198637
xfs: set superblock buffer type correctly

When the superblock is modified in a transaction, the commonly
modified fields are not actually copied to the superblock buffer to
avoid the buffer lock becoming a serialisation point. However, there
are some other operations that modify the superblock fields within
the transaction that don't directly log to the superblock but rely
on the changes to be applied during the transaction commit (to
minimise the buffer lock hold time).

When we do this, we fail to mark the buffer log item as being a
superblock buffer and that can lead to the buffer not being marked
with the corect type in the log and hence causing recovery issues.
Fix it by setting the type correctly, similar to xfs_mod_sb()...

cc: <stable@vger.kernel.org> # 3.10 to current
Tested-by: Jan Kara <jack@suse.cz>
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
fs/xfs/xfs_trans.c