drm/i915: Document that mmap forwarding is discouraged
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Thu, 16 Oct 2014 10:28:18 +0000 (12:28 +0200)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Fri, 24 Oct 2014 14:34:04 +0000 (16:34 +0200)
commit343673818098b80e5adca6a93d4e112d907cd293
treed34aa63d43711c0edf2758159b9409e11cc678a7
parent101b376d358e2f724db5e0ac4d207079b16c4754
drm/i915: Document that mmap forwarding is discouraged

Too many new drm driver writers seem to look at i915 for inspiration.
But we have two ways to do mmap, so discourage readers from the old,
ugly version. In a new driver we'd just expose two mmap offsets per
object, one for the gtt map and the other for the cpu map.

v2: Make it clear that i915 does cpu mmaps this way for past
cluelessness^W^W historical reasons. Asked for by Jani.

Cc: "Cheng, Yao" <yao.cheng@intel.com>
Cc: David Herrmann <dh.herrmann@gmail.com>
Reviewed-by: David Herrmann <dh.herrmann@gmail.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/i915_gem.c