net: add real socket cookies
authorEric Dumazet <edumazet@google.com>
Thu, 12 Mar 2015 01:53:14 +0000 (18:53 -0700)
committerDavid S. Miller <davem@davemloft.net>
Thu, 12 Mar 2015 01:55:28 +0000 (21:55 -0400)
commit33cf7c90fe2f97afb1cadaa0cfb782cb9d1b9ee2
tree7a0c80d0b2bb618919d966ce5b827c7eb8f843f6
parent654eff45166c7e89d18fc476325c975768b2e347
net: add real socket cookies

A long standing problem in netlink socket dumps is the use
of kernel socket addresses as cookies.

1) It is a security concern.

2) Sockets can be reused quite quickly, so there is
   no guarantee a cookie is used once and identify
   a flow.

3) request sock, establish sock, and timewait socks
   for a given flow have different cookies.

Part of our effort to bring better TCP statistics requires
to switch to a different allocator.

In this patch, I chose to use a per network namespace 64bit generator,
and to use it only in the case a socket needs to be dumped to netlink.
(This might be refined later if needed)

Note that I tried to carry cookies from request sock, to establish sock,
then timewait sockets.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Eric Salo <salo@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
13 files changed:
include/linux/sock_diag.h
include/net/inet_sock.h
include/net/inet_timewait_sock.h
include/net/net_namespace.h
include/net/sock.h
net/core/sock.c
net/core/sock_diag.c
net/dccp/ipv4.c
net/ipv4/inet_connection_sock.c
net/ipv4/inet_diag.c
net/ipv4/inet_timewait_sock.c
net/ipv4/syncookies.c
net/ipv4/tcp_input.c