drivers/gpu/drm/ttm/ttm_page_alloc_dma.c: Remove useless kfree
authorPeter Senna Tschudin <peter.senna@gmail.com>
Wed, 12 Sep 2012 15:06:41 +0000 (15:06 +0000)
committerDave Airlie <airlied@redhat.com>
Mon, 1 Oct 2012 23:33:26 +0000 (09:33 +1000)
commit33cce6e9801f7d0184a636e9096a7cf7f8237ff9
treeb278feda67010def1d090e4b4b0f14770b4dce3d
parent3184009c36da413724f283e3c7ac9cc60c623bc4
drivers/gpu/drm/ttm/ttm_page_alloc_dma.c: Remove useless kfree

Remove useless kfree() and clean up code related to the removal.

The semantic patch that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@r exists@
position p1,p2;
expression x;
@@

if (x@p1 == NULL) { ... kfree@p2(x); ... return ...; }

@unchanged exists@
position r.p1,r.p2;
expression e <= r.x,x,e1;
iterator I;
statement S;
@@

if (x@p1 == NULL) { ... when != I(x,...) S
                        when != e = e1
                        when != e += e1
                        when != e -= e1
                        when != ++e
                        when != --e
                        when != e++
                        when != e--
                        when != &e
   kfree@p2(x); ... return ...; }

@ok depends on unchanged exists@
position any r.p1;
position r.p2;
expression x;
@@

... when != true x@p1 == NULL
kfree@p2(x);

@depends on !ok && unchanged@
position r.p2;
expression x;
@@

*kfree@p2(x);
// </smpl>

Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>
drivers/gpu/drm/ttm/ttm_page_alloc_dma.c