net:nfc:digital: Fix a double free in digital_tg_recv_dep_req
authorLv Yunlong <lyl2019@mail.ustc.edu.cn>
Tue, 27 Apr 2021 16:22:58 +0000 (09:22 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 22 May 2021 08:40:28 +0000 (10:40 +0200)
commit312e4bc83fc9a28f2ca8a8ad494367f6730ab0f9
tree374de83d3ab78752754cd85e20d72ffbdbecbaf0
parentc7f75d11fe72913d2619f97b2334b083cd7bb955
net:nfc:digital: Fix a double free in digital_tg_recv_dep_req

[ Upstream commit 75258586793efc521e5dd52a5bf6c7a4cf7002be ]

In digital_tg_recv_dep_req, it calls nfc_tm_data_received(..,resp).
If nfc_tm_data_received() failed, the callee will free the resp via
kfree_skb() and return error. But in the exit branch, the resp
will be freed again.

My patch sets resp to NULL if nfc_tm_data_received() failed, to
avoid the double free.

Fixes: 1c7a4c24fbfd9 ("NFC Digital: Add target NFC-DEP support")
Signed-off-by: Lv Yunlong <lyl2019@mail.ustc.edu.cn>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/nfc/digital_dep.c