udp: Fix inverted NAPI_GRO_CB(skb)->flush test
authorScott Wood <scottwood@freescale.com>
Thu, 11 Sep 2014 02:23:18 +0000 (21:23 -0500)
committerDavid S. Miller <davem@davemloft.net>
Fri, 12 Sep 2014 21:55:41 +0000 (17:55 -0400)
commit2d8f7e2c8a63131828e8d4e2d98835399f27319e
tree6b0e954495b7b096baca4021d84bb8438ba7fc22
parentc5306726bc619be21303c55e09aac317072b3c25
udp: Fix inverted NAPI_GRO_CB(skb)->flush test

Commit 2abb7cdc0d ("udp: Add support for doing checksum unnecessary
conversion") caused napi_gro_cb structs with the "flush" field zero to
take the "udp_gro_receive" path rather than the "set flush to 1" path
that they would previously take.  As a result I saw booting from an NFS
root hang shortly after starting userspace, with "server not
responding" messages.

This change to the handling of "flush == 0" packets appears to be
incidental to the goal of adding new code in the case where
skb_gro_checksum_validate_zero_check() returns zero.  Based on that and
the fact that it breaks things, I'm assuming that it is unintentional.

Fixes: 2abb7cdc0d ("udp: Add support for doing checksum unnecessary conversion")
Cc: Tom Herbert <therbert@google.com>
Signed-off-by: Scott Wood <scottwood@freescale.com>
Acked-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/udp_offload.c
net/ipv6/udp_offload.c