kprobes/x86: Check for invalid ftrace location in __recover_probed_insn()
authorPetr Mladek <pmladek@suse.cz>
Fri, 20 Feb 2015 14:07:30 +0000 (15:07 +0100)
committerIngo Molnar <mingo@kernel.org>
Sat, 21 Feb 2015 09:33:31 +0000 (10:33 +0100)
commit2a6730c8b6e075adf826a89a3e2caa705807afdb
tree05620565e26b29ba355b8241b2b80c6c0189ef52
parent650b7b23cb1e32d77daeefbac1ceb1329abf3b23
kprobes/x86: Check for invalid ftrace location in __recover_probed_insn()

__recover_probed_insn() should always be called from an address
where an instructions starts. The check for ftrace_location()
might help to discover a potential inconsistency.

This patch adds WARN_ON() when the inconsistency is detected.
Also it adds handling of the situation when the original code
can not get recovered.

Suggested-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Signed-off-by: Petr Mladek <pmladek@suse.cz>
Cc: Ananth NMavinakayanahalli <ananth@in.ibm.com>
Cc: Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>
Cc: David S. Miller <davem@davemloft.net>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Jiri Kosina <jkosina@suse.cz>
Cc: Steven Rostedt <rostedt@goodmis.org>
Link: http://lkml.kernel.org/r/1424441250-27146-3-git-send-email-pmladek@suse.cz
Signed-off-by: Ingo Molnar <mingo@kernel.org>
arch/x86/kernel/kprobes/core.c
arch/x86/kernel/kprobes/opt.c