irqchip: gicv3-its: Fix encoding of collection's target redistributor
authorMarc Zyngier <marc.zyngier@arm.com>
Fri, 27 Mar 2015 14:15:02 +0000 (14:15 +0000)
committerJason Cooper <jason@lakedaemon.net>
Sun, 29 Mar 2015 19:25:45 +0000 (19:25 +0000)
commit263fcd312deffb9bf10f007f958dccfa64a807f5
treec424529594bcb4798dc802860e67fbd0f6600d78
parent4559fbb3a9b1bde46afc739fa6c300826acdc19c
irqchip: gicv3-its: Fix encoding of collection's target redistributor

With a monolithic GICv3, redistributors are addressed using a linear
number, while a distributed implementation uses physical addresses.

When encoding a target address into a command, we strip the lower
16 bits, as redistributors are always 64kB aligned. This works
perfectly well with a distributed implementation, but has the
silly effect of always encoding target 0 in the monolithic case
(unless you have more than 64k CPUs, of course).

The obvious fix is to shift the linear target number by 16 when
computing the target address, so that we don't loose any precious
bit.

Reported-by: Andre Przywara <andre.przywara@arm.com>
Tested-by: Andre Przywara <andre.przywara@arm.com>
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
Link: https://lkml.kernel.org/r/1427465705-17126-2-git-send-email-marc.zyngier@arm.com
Signed-off-by: Jason Cooper <jason@lakedaemon.net>
drivers/irqchip/irq-gic-v3-its.c