signal: fix information leak in copy_siginfo_to_user
authorAmanieu d'Antras <amanieu@gmail.com>
Thu, 6 Aug 2015 22:46:29 +0000 (15:46 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Fri, 7 Aug 2015 01:39:40 +0000 (04:39 +0300)
commit26135022f85105ad725cda103fa069e29e83bd16
tree5e4f34c68105b76a88b96c467be46994d70fa5f8
parent3c00cb5e68dc719f2fc73a33b1b230aadfcb1309
signal: fix information leak in copy_siginfo_to_user

This function may copy the si_addr_lsb, si_lower and si_upper fields to
user mode when they haven't been initialized, which can leak kernel
stack data to user mode.

Just checking the value of si_code is insufficient because the same
si_code value is shared between multiple signals.  This is solved by
checking the value of si_signo in addition to si_code.

Signed-off-by: Amanieu d'Antras <amanieu@gmail.com>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Russell King <rmk@arm.linux.org.uk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
arch/arm64/kernel/signal32.c
kernel/signal.c